DB 입출력시의 타입 가드 추가

This commit is contained in:
static
2024-12-29 16:54:48 +09:00
parent 516375142d
commit 46938ef700
6 changed files with 18 additions and 23 deletions

View File

@@ -1,6 +1,6 @@
import { and, eq, gt, lte } from "drizzle-orm"; import { and, eq, gt, lte } from "drizzle-orm";
import db from "./drizzle"; import db from "./drizzle";
import { client, userClient, userClientChallenge, UserClientState } from "./schema"; import { client, userClient, userClientChallenge } from "./schema";
export const createClient = async (pubKey: string, userId: number) => { export const createClient = async (pubKey: string, userId: number) => {
return await db.transaction(async (tx) => { return await db.transaction(async (tx) => {
@@ -33,12 +33,12 @@ export const getUserClient = async (userId: number, clientId: number) => {
export const setUserClientStateToPending = async (userId: number, clientId: number) => { export const setUserClientStateToPending = async (userId: number, clientId: number) => {
await db await db
.update(userClient) .update(userClient)
.set({ state: UserClientState.Pending }) .set({ state: "pending" })
.where( .where(
and( and(
eq(userClient.userId, userId), eq(userClient.userId, userId),
eq(userClient.clientId, clientId), eq(userClient.clientId, clientId),
eq(userClient.state, UserClientState.Challenging), eq(userClient.state, "challenging"),
), ),
) )
.execute(); .execute();
@@ -49,7 +49,7 @@ export const createUserClientChallenge = async (
clientId: number, clientId: number,
challenge: string, challenge: string,
allowedIp: string, allowedIp: string,
expiresAt: number, expiresAt: Date,
) => { ) => {
await db await db
.insert(userClientChallenge) .insert(userClientChallenge)
@@ -71,7 +71,7 @@ export const getUserClientChallenge = async (challenge: string, ip: string) => {
and( and(
eq(userClientChallenge.challenge, challenge), eq(userClientChallenge.challenge, challenge),
eq(userClientChallenge.allowedIp, ip), eq(userClientChallenge.allowedIp, ip),
gt(userClientChallenge.expiresAt, Date.now()), gt(userClientChallenge.expiresAt, new Date()),
), ),
) )
.execute(); .execute();
@@ -81,6 +81,6 @@ export const getUserClientChallenge = async (challenge: string, ip: string) => {
export const cleanupExpiredUserClientChallenges = async () => { export const cleanupExpiredUserClientChallenges = async () => {
await db await db
.delete(userClientChallenge) .delete(userClientChallenge)
.where(lte(userClientChallenge.expiresAt, Date.now())) .where(lte(userClientChallenge.expiresAt, new Date()))
.execute(); .execute();
}; };

View File

@@ -1,15 +1,9 @@
import { sqliteTable, text, integer, primaryKey } from "drizzle-orm/sqlite-core"; import { sqliteTable, text, integer, primaryKey } from "drizzle-orm/sqlite-core";
import { user } from "./user"; import { user } from "./user";
export enum UserClientState {
Challenging = 0,
Pending = 1,
Active = 2,
}
export const client = sqliteTable("client", { export const client = sqliteTable("client", {
id: integer("id").primaryKey(), id: integer("id").primaryKey(),
pubKey: text("public_key").notNull().unique(), pubKey: text("public_key").notNull().unique(), // Base64
}); });
export const userClient = sqliteTable( export const userClient = sqliteTable(
@@ -21,7 +15,9 @@ export const userClient = sqliteTable(
clientId: integer("client_id") clientId: integer("client_id")
.notNull() .notNull()
.references(() => client.id), .references(() => client.id),
state: integer("state").notNull().default(UserClientState.Challenging), state: text("state", { enum: ["challenging", "pending", "active"] })
.notNull()
.default("challenging"),
encKey: text("encrypted_key"), encKey: text("encrypted_key"),
}, },
(t) => ({ (t) => ({
@@ -37,7 +33,7 @@ export const userClientChallenge = sqliteTable("user_client_challenge", {
clientId: integer("client_id") clientId: integer("client_id")
.notNull() .notNull()
.references(() => client.id), .references(() => client.id),
challenge: text("challenge").notNull().unique(), challenge: text("challenge").notNull().unique(), // Base64
allowedIp: text("allowed_ip").notNull(), allowedIp: text("allowed_ip").notNull(),
expiresAt: integer("expires_at").notNull(), expiresAt: integer("expires_at", { mode: "timestamp_ms" }).notNull(),
}); });

View File

@@ -10,7 +10,7 @@ export const refreshToken = sqliteTable(
.notNull() .notNull()
.references(() => user.id), .references(() => user.id),
clientId: integer("client_id").references(() => client.id), clientId: integer("client_id").references(() => client.id),
expiresAt: integer("expires_at").notNull(), // Only used for cleanup expiresAt: integer("expires_at", { mode: "timestamp_ms" }).notNull(), // Only used for cleanup
}, },
(t) => ({ (t) => ({
unq: unique().on(t.userId, t.clientId), unq: unique().on(t.userId, t.clientId),

View File

@@ -6,7 +6,7 @@ import db from "./drizzle";
import { refreshToken } from "./schema"; import { refreshToken } from "./schema";
const expiresIn = ms(env.jwt.refreshExp); const expiresIn = ms(env.jwt.refreshExp);
const expiresAt = () => Date.now() + expiresIn; const expiresAt = () => new Date(Date.now() + expiresIn);
export const registerRefreshToken = async ( export const registerRefreshToken = async (
userId: number, userId: number,
@@ -71,5 +71,5 @@ export const revokeRefreshToken = async (tokenId: string) => {
}; };
export const cleanupExpiredRefreshTokens = async () => { export const cleanupExpiredRefreshTokens = async () => {
await db.delete(refreshToken).where(lte(refreshToken.expiresAt, Date.now())).execute(); await db.delete(refreshToken).where(lte(refreshToken.expiresAt, new Date())).execute();
}; };

View File

@@ -10,7 +10,6 @@ import {
upgradeRefreshToken, upgradeRefreshToken,
revokeRefreshToken, revokeRefreshToken,
} from "$lib/server/db/token"; } from "$lib/server/db/token";
import { UserClientState } from "$lib/server/db/schema";
import { issueToken, verifyToken, TokenError } from "$lib/server/modules/auth"; import { issueToken, verifyToken, TokenError } from "$lib/server/modules/auth";
const verifyPassword = async (hash: string, password: string) => { const verifyPassword = async (hash: string, password: string) => {
@@ -41,7 +40,7 @@ export const login = async (email: string, password: string, pubKey?: string) =>
const userClient = client ? await getUserClient(user.id, client.id) : undefined; const userClient = client ? await getUserClient(user.id, client.id) : undefined;
if (client === null) { if (client === null) {
error(401, "Invalid public key"); error(401, "Invalid public key");
} else if (client && (!userClient || userClient.state === UserClientState.Challenging)) { } else if (client && (!userClient || userClient.state === "challenging")) {
error(401, "Unregistered public key"); error(401, "Unregistered public key");
} }
@@ -99,7 +98,7 @@ export const upgradeTokens = async (refreshToken: string, pubKey: string) => {
const userClient = client ? await getUserClient(userId, client.id) : undefined; const userClient = client ? await getUserClient(userId, client.id) : undefined;
if (!client) { if (!client) {
error(401, "Invalid public key"); error(401, "Invalid public key");
} else if (client && (!userClient || userClient.state === UserClientState.Challenging)) { } else if (client && (!userClient || userClient.state === "challenging")) {
error(401, "Unregistered public key"); error(401, "Unregistered public key");
} }

View File

@@ -14,7 +14,7 @@ import {
import env from "$lib/server/loadenv"; import env from "$lib/server/loadenv";
const expiresIn = ms(env.challenge.pubKeyExp); const expiresIn = ms(env.challenge.pubKeyExp);
const expiresAt = () => Date.now() + expiresIn; const expiresAt = () => new Date(Date.now() + expiresIn);
const generateChallenge = async (userId: number, ip: string, clientId: number, pubKey: string) => { const generateChallenge = async (userId: number, ip: string, clientId: number, pubKey: string) => {
const challenge = await promisify(randomBytes)(32); const challenge = await promisify(randomBytes)(32);