삭제된 파일의 캐시가 존재하는 경우 캐시 페이지의 로딩이 끝나지 않는 버그 수정

This commit is contained in:
static
2026-01-01 21:41:53 +09:00
parent 182ec18a2b
commit 841c57e8fc
16 changed files with 98 additions and 59 deletions

View File

@@ -1,9 +1,9 @@
import * as IndexedDB from "$lib/indexedDB";
import { trpc, isTRPCClientError } from "$trpc/client";
import { FilesystemCache, decryptFileMetadata, decryptCategoryMetadata } from "./internal.svelte";
import type { CategoryInfo } from "./types";
import type { MaybeCategoryInfo } from "./types";
const cache = new FilesystemCache<CategoryId, CategoryInfo, Partial<CategoryInfo>>();
const cache = new FilesystemCache<CategoryId, MaybeCategoryInfo, Partial<MaybeCategoryInfo>>();
const fetchFromIndexedDB = async (id: CategoryId) => {
const [category, subCategories] = await Promise.all([
@@ -29,10 +29,15 @@ const fetchFromIndexedDB = async (id: CategoryId) => {
: undefined;
if (id === "root") {
return { id, subCategories };
return {
id,
exists: true as const,
subCategories,
};
} else if (category) {
return {
id,
exists: true as const,
name: category.name,
subCategories,
files: files!.filter((file) => !!file),
@@ -68,10 +73,15 @@ const fetchFromServer = async (id: CategoryId, masterKey: CryptoKey) => {
]);
if (id === "root") {
return { id, subCategories };
return {
id,
exists: true as const,
subCategories,
};
} else {
return {
id,
exists: true as const,
subCategories,
files,
...(await decryptCategoryMetadata(metadata!, masterKey)),
@@ -79,9 +89,8 @@ const fetchFromServer = async (id: CategoryId, masterKey: CryptoKey) => {
}
} catch (e) {
if (isTRPCClientError(e) && e.data?.code === "NOT_FOUND") {
cache.delete(id);
await IndexedDB.deleteCategoryInfo(id as number);
return;
return { id, exists: false as const };
}
throw e;
}

View File

@@ -2,9 +2,9 @@ import * as IndexedDB from "$lib/indexedDB";
import { monotonicResolve } from "$lib/utils";
import { trpc, isTRPCClientError } from "$trpc/client";
import { FilesystemCache, decryptDirectoryMetadata, decryptFileMetadata } from "./internal.svelte";
import type { DirectoryInfo } from "./types";
import type { MaybeDirectoryInfo } from "./types";
const cache = new FilesystemCache<DirectoryId, DirectoryInfo>();
const cache = new FilesystemCache<DirectoryId, MaybeDirectoryInfo>();
const fetchFromIndexedDB = async (id: DirectoryId) => {
const [directory, subDirectories, files] = await Promise.all([
@@ -14,9 +14,21 @@ const fetchFromIndexedDB = async (id: DirectoryId) => {
]);
if (id === "root") {
return { id, subDirectories, files };
return {
id,
exists: true as const,
subDirectories,
files,
};
} else if (directory) {
return { id, parentId: directory.parentId, name: directory.name, subDirectories, files };
return {
id,
exists: true as const,
parentId: directory.parentId,
name: directory.name,
subDirectories,
files,
};
}
};
@@ -44,10 +56,16 @@ const fetchFromServer = async (id: DirectoryId, masterKey: CryptoKey) => {
]);
if (id === "root") {
return { id, subDirectories, files };
return {
id,
exists: true as const,
subDirectories,
files,
};
} else {
return {
id,
exists: true as const,
parentId: metadata!.parent,
subDirectories,
files,
@@ -56,9 +74,8 @@ const fetchFromServer = async (id: DirectoryId, masterKey: CryptoKey) => {
}
} catch (e) {
if (isTRPCClientError(e) && e.data?.code === "NOT_FOUND") {
cache.delete(id);
await IndexedDB.deleteDirectoryInfo(id as number);
return;
return { id, exists: false as const };
}
throw e;
}

View File

@@ -2,9 +2,9 @@ import * as IndexedDB from "$lib/indexedDB";
import { monotonicResolve } from "$lib/utils";
import { trpc, isTRPCClientError } from "$trpc/client";
import { FilesystemCache, decryptFileMetadata, decryptCategoryMetadata } from "./internal.svelte";
import type { FileInfo } from "./types";
import type { MaybeFileInfo } from "./types";
const cache = new FilesystemCache<number, FileInfo>();
const cache = new FilesystemCache<number, MaybeFileInfo>();
const fetchFromIndexedDB = async (id: number) => {
const file = await IndexedDB.getFileInfo(id);
@@ -20,6 +20,7 @@ const fetchFromIndexedDB = async (id: number) => {
if (file) {
return {
id,
exists: true as const,
parentId: file.parentId,
contentType: file.contentType,
name: file.name,
@@ -44,6 +45,7 @@ const fetchFromServer = async (id: number, masterKey: CryptoKey) => {
return {
id,
exists: true as const,
parentId: metadata.parent,
contentType: metadata.contentType,
contentIv: metadata.contentIv,
@@ -52,9 +54,8 @@ const fetchFromServer = async (id: number, masterKey: CryptoKey) => {
};
} catch (e) {
if (isTRPCClientError(e) && e.data?.code === "NOT_FOUND") {
cache.delete(id);
await IndexedDB.deleteFileInfo(id);
return;
return { id, exists: false as const };
}
throw e;
}

View File

@@ -30,10 +30,6 @@ export class FilesystemCache<K, V extends RV, RV = V> {
return info ?? promise;
}
delete(key: K) {
this.map.delete(key);
}
}
export const decryptDirectoryMetadata = async (

View File

@@ -1,4 +1,5 @@
export type DataKey = { key: CryptoKey; version: Date };
type AllUndefined<T> = { [K in keyof T]?: undefined };
interface LocalDirectoryInfo {
id: number;
@@ -20,6 +21,9 @@ interface RootDirectoryInfo {
export type DirectoryInfo = LocalDirectoryInfo | RootDirectoryInfo;
export type SubDirectoryInfo = Omit<LocalDirectoryInfo, "parentId" | "subDirectories" | "files">;
export type MaybeDirectoryInfo =
| (DirectoryInfo & { exists: true })
| ({ id: DirectoryId; exists: false } & AllUndefined<Omit<DirectoryInfo, "id">>);
export interface FileInfo {
id: number;
@@ -35,6 +39,9 @@ export interface FileInfo {
export type SummarizedFileInfo = Omit<FileInfo, "parentId" | "contentIv" | "categories">;
export type CategoryFileInfo = SummarizedFileInfo & { isRecursive: boolean };
export type MaybeFileInfo =
| (FileInfo & { exists: true })
| ({ id: number; exists: false } & AllUndefined<Omit<FileInfo, "id">>);
interface LocalCategoryInfo {
id: number;
@@ -59,3 +66,6 @@ export type SubCategoryInfo = Omit<
LocalCategoryInfo,
"subCategories" | "files" | "isFileRecursive"
>;
export type MaybeCategoryInfo =
| (CategoryInfo & { exists: true })
| ({ id: CategoryId; exists: false } & AllUndefined<Omit<CategoryInfo, "id">>);

View File

@@ -5,7 +5,7 @@
import { page } from "$app/state";
import { FullscreenDiv } from "$lib/components/atoms";
import { Categories, IconEntryButton, TopBar } from "$lib/components/molecules";
import { getFileInfo, type FileInfo } from "$lib/modules/filesystem";
import { getFileInfo, type FileInfo, type MaybeFileInfo } from "$lib/modules/filesystem";
import { captureVideoThumbnail } from "$lib/modules/thumbnail";
import { getFileDownloadState } from "$lib/modules/file";
import { masterKeyStore } from "$lib/stores";
@@ -26,7 +26,7 @@
let { data } = $props();
let infoPromise: Promise<FileInfo | null> | undefined = $state();
let infoPromise: Promise<MaybeFileInfo> | undefined = $state();
let info: FileInfo | null = $state(null);
let downloadState = $derived(getFileDownloadState(data.id));
@@ -75,7 +75,9 @@
$effect(() => {
infoPromise = getFileInfo(data.id, $masterKeyStore?.get(1)?.key!).then((fileInfo) => {
if (fileInfo.exists) {
info = fileInfo;
}
return fileInfo;
});
info = null;

View File

@@ -2,7 +2,7 @@
import { BottomDiv, BottomSheet, Button, FullscreenDiv } from "$lib/components/atoms";
import { SubCategories } from "$lib/components/molecules";
import { CategoryCreateModal } from "$lib/components/organisms";
import { getCategoryInfo, type CategoryInfo } from "$lib/modules/filesystem";
import { getCategoryInfo, type MaybeCategoryInfo } from "$lib/modules/filesystem";
import { masterKeyStore } from "$lib/stores";
import { requestCategoryCreation } from "./service";
@@ -13,7 +13,7 @@
let { onAddToCategoryClick, isOpen = $bindable() }: Props = $props();
let categoryInfoPromise: Promise<CategoryInfo | null> | undefined = $state();
let categoryInfoPromise: Promise<MaybeCategoryInfo> | undefined = $state();
let isCategoryCreateModalOpen = $state(false);
@@ -25,7 +25,7 @@
</script>
{#await categoryInfoPromise then categoryInfo}
{#if categoryInfo}
{#if categoryInfo?.exists}
<BottomSheet bind:isOpen class="flex flex-col">
<FullscreenDiv>
<SubCategories

View File

@@ -23,7 +23,9 @@
{#await filesPromise then files}
<div class="space-y-2 pb-4">
{#each files as file, index}
{#if file.exists}
<File state={downloadingFiles[index]!} info={file} />
{/if}
{/each}
</div>
{/await}

View File

@@ -4,12 +4,12 @@
import { FullscreenDiv } from "$lib/components/atoms";
import { TopBar } from "$lib/components/molecules";
import { Gallery } from "$lib/components/organisms";
import { getFileInfo, type FileInfo } from "$lib/modules/filesystem";
import { getFileInfo, type MaybeFileInfo } from "$lib/modules/filesystem";
import { masterKeyStore } from "$lib/stores";
let { data } = $props();
let files: (FileInfo | null)[] = $state([]);
let files: MaybeFileInfo[] = $state([]);
onMount(async () => {
files = await Promise.all(
@@ -25,7 +25,7 @@
<TopBar title="사진 및 동영상" />
<FullscreenDiv>
<Gallery
files={files.filter((file) => !!file)}
files={files.filter((file) => file?.exists)}
onFileClick={({ id }) => goto(`/file/${id}?from=gallery`)}
/>
</FullscreenDiv>

View File

@@ -4,14 +4,14 @@
import { TopBar } from "$lib/components/molecules";
import type { FileCacheIndex } from "$lib/indexedDB";
import { getFileCacheIndex, deleteFileCache as doDeleteFileCache } from "$lib/modules/file";
import { getFileInfo, type FileInfo } from "$lib/modules/filesystem";
import { getFileInfo, type MaybeFileInfo } from "$lib/modules/filesystem";
import { masterKeyStore } from "$lib/stores";
import { formatFileSize } from "$lib/utils";
import File from "./File.svelte";
interface FileCache {
index: FileCacheIndex;
fileInfo: FileInfo | null;
info: MaybeFileInfo;
}
let fileCache: FileCache[] | undefined = $state();
@@ -26,7 +26,7 @@
fileCache = await Promise.all(
getFileCacheIndex().map(async (index) => ({
index,
fileInfo: await getFileInfo(index.fileId, $masterKeyStore?.get(1)?.key!),
info: await getFileInfo(index.fileId, $masterKeyStore?.get(1)?.key!),
})),
);
fileCache.sort((a, b) => a.index.lastRetrievedAt.getTime() - b.index.lastRetrievedAt.getTime());
@@ -55,8 +55,8 @@
<p>캐시를 삭제하더라도 원본 파일은 삭제되지 않아요.</p>
</div>
<div class="space-y-2">
{#each fileCache as { index, fileInfo }}
<File {index} info={fileInfo} onDeleteClick={deleteFileCache} />
{#each fileCache as { index, info }}
<File {index} {info} onDeleteClick={deleteFileCache} />
{/each}
</div>
</div>

View File

@@ -1,6 +1,6 @@
<script lang="ts">
import type { FileCacheIndex } from "$lib/indexedDB";
import type { SummarizedFileInfo } from "$lib/modules/filesystem";
import type { MaybeFileInfo } from "$lib/modules/filesystem";
import { formatDate, formatFileSize } from "$lib/utils";
import IconDraft from "~icons/material-symbols/draft";
@@ -9,7 +9,7 @@
interface Props {
index: FileCacheIndex;
info: SummarizedFileInfo | null;
info: MaybeFileInfo;
onDeleteClick: (fileId: number) => void;
}
@@ -17,7 +17,7 @@
</script>
<div class="flex h-14 items-center gap-x-4 p-2">
{#if info}
{#if info.exists}
<div class="flex-shrink-0 rounded-full bg-blue-100 p-1 text-xl">
<IconDraft class="text-blue-400" />
</div>
@@ -27,7 +27,7 @@
</div>
{/if}
<div class="flex-grow overflow-hidden">
{#if info}
{#if info.exists}
<p title={info.name} class="truncate font-medium">{info.name}</p>
{:else}
<p class="font-medium">삭제된 파일</p>

View File

@@ -1,6 +1,5 @@
<script lang="ts">
import { onMount } from "svelte";
import { get } from "svelte/store";
import { goto } from "$app/navigation";
import { BottomDiv, Button, FullscreenDiv } from "$lib/components/atoms";
import { IconEntryButton, TopBar } from "$lib/components/molecules";
@@ -15,12 +14,13 @@
} from "./service.svelte";
import IconDelete from "~icons/material-symbols/delete";
import { file } from "zod";
let { data } = $props();
const generateAllThumbnails = () => {
persistentStates.files.forEach(({ info }) => {
if (info) {
if (info.exists) {
requestThumbnailGeneration(info);
}
});
@@ -58,12 +58,14 @@
</p>
<div class="space-y-2">
{#each persistentStates.files as { info, status }}
{#if info.exists}
<File
{info}
generationStatus={status}
onclick={({ id }) => goto(`/file/${id}`)}
onGenerateThumbnailClick={requestThumbnailGeneration}
/>
{/if}
{/each}
</div>
</div>

View File

@@ -2,7 +2,7 @@ import { limitFunction } from "p-limit";
import { get, writable, type Writable } from "svelte/store";
import { encryptData } from "$lib/modules/crypto";
import { storeFileThumbnailCache } from "$lib/modules/file";
import type { FileInfo } from "$lib/modules/filesystem";
import type { FileInfo, MaybeFileInfo } from "$lib/modules/filesystem";
import { generateThumbnail as doGenerateThumbnail } from "$lib/modules/thumbnail";
import { requestFileDownload, requestFileThumbnailUpload } from "$lib/services/file";
@@ -17,7 +17,7 @@ export type GenerationStatus =
interface File {
id: number;
info: FileInfo;
info: MaybeFileInfo;
status?: Writable<GenerationStatus>;
}

View File

@@ -2,7 +2,7 @@
import { goto } from "$app/navigation";
import { TopBar } from "$lib/components/molecules";
import { Category, CategoryCreateModal } from "$lib/components/organisms";
import { getCategoryInfo, type CategoryInfo } from "$lib/modules/filesystem";
import { getCategoryInfo, type MaybeCategoryInfo } from "$lib/modules/filesystem";
import { masterKeyStore } from "$lib/stores";
import CategoryDeleteModal from "./CategoryDeleteModal.svelte";
import CategoryMenuBottomSheet from "./CategoryMenuBottomSheet.svelte";
@@ -18,7 +18,7 @@
let { data } = $props();
let context = createContext();
let infoPromise: Promise<CategoryInfo> | undefined = $state();
let infoPromise: Promise<MaybeCategoryInfo> | undefined = $state();
let isCategoryCreateModalOpen = $state(false);
let isCategoryMenuBottomSheetOpen = $state(false);
@@ -35,7 +35,7 @@
</svelte:head>
{#await infoPromise then info}
{#if info}
{#if info?.exists}
{#if info.id !== "root"}
<TopBar title={info.name} />
{/if}

View File

@@ -4,7 +4,7 @@
import { page } from "$app/state";
import { FloatingButton } from "$lib/components/atoms";
import { TopBar } from "$lib/components/molecules";
import { getDirectoryInfo, type DirectoryInfo } from "$lib/modules/filesystem";
import { getDirectoryInfo, type MaybeDirectoryInfo } from "$lib/modules/filesystem";
import { masterKeyStore, hmacSecretStore } from "$lib/stores";
import DirectoryCreateModal from "./DirectoryCreateModal.svelte";
import DirectoryEntries from "./DirectoryEntries";
@@ -29,7 +29,7 @@
let { data } = $props();
let context = createContext();
let infoPromise: Promise<DirectoryInfo> | undefined = $state();
let infoPromise: Promise<MaybeDirectoryInfo> | undefined = $state();
let fileInput: HTMLInputElement | undefined = $state();
let duplicatedFile: File | undefined = $state();
let resolveForDuplicateFileModal: ((res: boolean) => void) | undefined = $state();
@@ -89,7 +89,7 @@
<input bind:this={fileInput} onchange={uploadFile} type="file" multiple class="hidden" />
{#await infoPromise then info}
{#if info}
{#if info?.exists}
<div class="flex h-full flex-col">
{#if showTopBar}
<TopBar title={info.name} class="flex-shrink-0" />

View File

@@ -2,11 +2,11 @@
import { onMount } from "svelte";
import { goto } from "$app/navigation";
import { EntryButton, FileThumbnailButton } from "$lib/components/atoms";
import { getFileInfo, type FileInfo } from "$lib/modules/filesystem";
import { getFileInfo, type MaybeFileInfo } from "$lib/modules/filesystem";
import { masterKeyStore } from "$lib/stores";
import { requestFreshMediaFilesRetrieval } from "./service";
let mediaFiles: (FileInfo | null)[] = $state([]);
let mediaFiles: MaybeFileInfo[] = $state([]);
onMount(async () => {
const files = await requestFreshMediaFilesRetrieval();
@@ -29,7 +29,7 @@
{#if mediaFiles.length > 0}
<div class="grid grid-cols-4 gap-2 p-2">
{#each mediaFiles as file}
{#if file}
{#if file.exists}
<FileThumbnailButton info={file} onclick={({ id }) => goto(`/file/${id}`)} />
{/if}
{/each}